Ddls 392 Secrets KMS #1722

jamesrwarren · 2024-11-06T14:06:46Z

Purpose

Initial PR to modify the secrets KMS

Two parts. Part 1 brings in the kms key.

Part 2 will update the roles to be able to decrypt the secrets and add the keys to the secrets

NA

I have performed a self-review of my own code
I have updated documentation (Confluence/ADR/tech debt doc) where relevant
I have added tests to prove my work
The product team have approved these changes
I have checked my work for potential security issues and refered to the OWASP top 10

I have run an in-browser accessibility test (e.g. WAVE, Lighthouse)
There are no deprecated CSS classes noted in the profiler
Translations are used and the profiler doesn't identify any missing
Any links or buttons added are screen reader friendly and contextually complete
If adding GA events, I have updated or checked the existing category or label values

DDLS-390 add additional checks on github action workflows (#1717)

33ebae7

jamesrwarren changed the title ~~Ddls 392~~ Ddls 392 Secrets KMS Nov 6, 2024

jamesrwarren marked this pull request as ready for review November 6, 2024 14:18

jamesrwarren requested a review from a team as a code owner November 6, 2024 14:18

Gugandeep previously approved these changes Nov 7, 2024

View reviewed changes

jamesrwarren added 2 commits November 7, 2024 15:18

DDLS-392 add cmk to secrets part 1 of 2

fbc6b8c

Merge branch 'main' of github.com:ministryofjustice/opg-digideps into D…

cc673f2

…DLS-392

jamesrwarren dismissed Gugandeep’s stale review via cc673f2 November 7, 2024 15:20

jamesrwarren force-pushed the DDLS-392 branch from b8be1f7 to cc673f2 Compare November 7, 2024 15:20

Merge branch 'main' of github.com:ministryofjustice/opg-digideps into D…

527f729

…DLS-392

Gugandeep approved these changes Nov 7, 2024

View reviewed changes

jamesrwarren merged commit ba0ec23 into main Nov 7, 2024
37 checks passed

jamesrwarren deleted the DDLS-392 branch November 7, 2024 17:12