Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDLS-373: Amend breadcrumbs for multi-client users #1729

Merged
merged 13 commits into from
Nov 21, 2024
Merged

DDLS-373: Amend breadcrumbs for multi-client users #1729

merged 13 commits into from
Nov 21, 2024

Conversation

MiaGordon91
Copy link
Contributor

@MiaGordon91 MiaGordon91 commented Nov 11, 2024

Purpose

Amend the breadcrumbs for multi-client deputy users in order to provide clearer user pathways when navigating the app.

Fixes DDLS-373

Approach

  • Correct breadcrumbs on the deputyship details, password and edit client page so that it renders the option to navigate back to choose a client page.
  • Correct list of breadcrumbs on the start and summary page of each report section to improve navigation from current page right through to the choose a client page
  • Apply the same solution to the summary pages of each report section
  • Update breadcrumbs on the review and declaration pages to improve navigation from current pages right through to the choose a client page
  • Update existing integration test to test against updated logic in macro

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about DigiDeps

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/ADR/tech debt doc) where relevant
  • I have added tests to prove my work
  • The product team have approved these changes
  • I have checked my work for potential security issues and refered to the OWASP top 10

Frontend

  • I have run an in-browser accessibility test (e.g. WAVE, Lighthouse)
  • There are no deprecated CSS classes noted in the profiler
  • Translations are used and the profiler doesn't identify any missing
  • Any links or buttons added are screen reader friendly and contextually complete
  • If adding GA events, I have updated or checked the existing category or label values

@MiaGordon91 MiaGordon91 marked this pull request as ready for review November 13, 2024 12:32
@MiaGordon91 MiaGordon91 requested a review from a team as a code owner November 13, 2024 12:32
jamesrwarren
jamesrwarren previously approved these changes Nov 19, 2024
@MiaGordon91 MiaGordon91 merged commit 96dd359 into main Nov 21, 2024
37 checks passed
@MiaGordon91 MiaGordon91 deleted the DDLS-373 branch November 21, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants