Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDLS-408 add dynamodb kms key part 1 of 2 #1737

Merged
merged 4 commits into from
Nov 25, 2024
Merged

DDLS-408 add dynamodb kms key part 1 of 2 #1737

merged 4 commits into from
Nov 25, 2024

Conversation

jamesrwarren
Copy link
Contributor

@jamesrwarren jamesrwarren commented Nov 21, 2024

Purpose

Adding CMKs to dynamodb tables

Fixes DDLS-408

Approach

Part 1 of 2. Create the CMK and we can already add it to cleanup job dynamo table as ci already has ability to decrypt it.

However we can't add to the other one till we give the lambda permission which will be in part 2.

I've also added description to SG rules. This does recreate them but they're very quick to recreate.

Learning

NA

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/ADR/tech debt doc) where relevant
  • I have added tests to prove my work
  • The product team have approved these changes
  • I have checked my work for potential security issues and refered to the OWASP top 10

Frontend

  • I have run an in-browser accessibility test (e.g. WAVE, Lighthouse)
  • There are no deprecated CSS classes noted in the profiler
  • Translations are used and the profiler doesn't identify any missing
  • Any links or buttons added are screen reader friendly and contextually complete
  • If adding GA events, I have updated or checked the existing category or label values

@jamesrwarren jamesrwarren marked this pull request as ready for review November 21, 2024 14:50
@jamesrwarren jamesrwarren requested a review from a team as a code owner November 21, 2024 14:50
@jamesrwarren jamesrwarren merged commit 1aabf70 into main Nov 25, 2024
37 checks passed
@jamesrwarren jamesrwarren deleted the DDLS-408 branch November 25, 2024 16:55
jamesrwarren added a commit that referenced this pull request Nov 25, 2024
jamesrwarren added a commit that referenced this pull request Nov 25, 2024
jamesrwarren added a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants