Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDLS-425 restrict management ci to limited access #1772

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

jamesrwarren
Copy link
Contributor

@jamesrwarren jamesrwarren commented Dec 16, 2024

Purpose

restrict management ci to limited access to digideps resources on management account

Fixes DDLS-425

Approach

In event of security breach, this will stop any attacker being able to affect the DNS/secrets etc of other products that use the management account.

I have created a new policy in org infra and this PR uses that policy.

Once we're sure this works we need to remove the original management CI user completely and just use this one.

Learning

NA

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/ADR/tech debt doc) where relevant
  • I have added tests to prove my work
  • The product team have approved these changes
  • I have checked my work for potential security issues and refered to the OWASP top 10

Frontend

  • I have run an in-browser accessibility test (e.g. WAVE, Lighthouse)
  • There are no deprecated CSS classes noted in the profiler
  • Translations are used and the profiler doesn't identify any missing
  • Any links or buttons added are screen reader friendly and contextually complete
  • If adding GA events, I have updated or checked the existing category or label values

@jamesrwarren jamesrwarren changed the title DDLS-425 try out the new management DDLS-425 restrict management ci to limited access Dec 18, 2024
@jamesrwarren jamesrwarren marked this pull request as ready for review December 18, 2024 16:04
@jamesrwarren jamesrwarren requested a review from a team as a code owner December 18, 2024 16:04
@jamesrwarren jamesrwarren merged commit c201538 into main Dec 19, 2024
37 checks passed
@jamesrwarren jamesrwarren deleted the DDLS-425b branch December 19, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants