Skip to content

Commit

Permalink
Turn AuthenticationServiceTest into unit test
Browse files Browse the repository at this point in the history
  • Loading branch information
@MishNajam
MishNajam committed Oct 5, 2023
1 parent 7935932 commit 8027ab4
Show file tree
Hide file tree
Showing 3 changed files with 83 additions and 36 deletions.
83 changes: 55 additions & 28 deletions service-api/app/config/routes.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,34 @@

declare(strict_types=1);

use App\Handler\AccessForAllLpaConfirmationHandler;
use App\Handler\AccessForAllLpaValidationHandler;
use App\Handler\AddLpaConfirmationHandler;
use App\Handler\AddLpaValidationHandler;
use App\Handler\AuthHandler;
use App\Handler\CanPasswordResetHandler;
use App\Handler\CanResetEmailHandler;
use App\Handler\ChangePasswordHandler;
use App\Handler\CompleteChangeEmailHandler;
use App\Handler\CompleteDeleteAccountHandler;
use App\Handler\CompletePasswordResetHandler;
use App\Handler\HealthcheckHandler;
use App\Handler\LpasCollectionHandler;
use App\Handler\LpasResourceCodesCollectionHandler;
use App\Handler\LpasResourceHandler;
use App\Handler\LpasResourceImagesCollectionHandler;
use App\Handler\NotifyHandler;
use App\Handler\RequestChangeEmailHandler;
use App\Handler\RequestCleanseHandler;
use App\Handler\RequestPasswordResetHandler;
use App\Handler\UserActivateHandler;
use App\Handler\UserHandler;
use App\Handler\ViewerCodeFullHandler;
use App\Handler\ViewerCodeSummaryHandler;
use Mezzio\Application;
use Mezzio\MiddlewareFactory;
use Psr\Container\ContainerInterface;
use App\Handler\AuthRedirectHandler;

/**
* Setup routes with a single request method:
Expand Down Expand Up @@ -33,82 +58,84 @@
* );
*/
return function (Application $app, MiddlewareFactory $factory, ContainerInterface $container) : void {
$app->get('/healthcheck', App\Handler\HealthcheckHandler::class, 'healthcheck');
$app->get('/healthcheck', HealthcheckHandler::class, 'healthcheck');

$app->get('/v1/lpas', App\Handler\LpasCollectionHandler::class, 'lpa.collection');
$app->get('/v1/lpas', LpasCollectionHandler::class, 'lpa.collection');
$app->post(
'/v1/older-lpa/validate',
App\Handler\AccessForAllLpaValidationHandler::class,
AccessForAllLpaValidationHandler::class,
'lpa.older.validate'
);
$app->patch(
'/v1/older-lpa/confirm',
App\Handler\AccessForAllLpaConfirmationHandler::class,
AccessForAllLpaConfirmationHandler::class,
'lpa.older.confirm'
);

$app->post(
'/v1/older-lpa/cleanse',
App\Handler\RequestCleanseHandler::class,
RequestCleanseHandler::class,
'lpa.older.cleanse'
);

$app->get('/v1/lpas/{user-lpa-actor-token:[0-9a-f\-]+}', App\Handler\LpasResourceHandler::class, 'lpa.resource');
$app->delete('/v1/lpas/{user-lpa-actor-token:[0-9a-f\-]+}', App\Handler\LpasResourceHandler::class, 'lpa.remove');
$app->get('/v1/lpas/{user-lpa-actor-token:[0-9a-f\-]+}', LpasResourceHandler::class, 'lpa.resource');
$app->delete('/v1/lpas/{user-lpa-actor-token:[0-9a-f\-]+}', LpasResourceHandler::class, 'lpa.remove');
$app->post(
'/v1/lpas/{user-lpa-actor-token:[0-9a-f\-]+}/codes',
App\Handler\LpasResourceCodesCollectionHandler::class,
LpasResourceCodesCollectionHandler::class,
'lpa.create.code'
);
$app->get(
'/v1/lpas/{user-lpa-actor-token:[0-9a-f\-]+}/codes',
App\Handler\LpasResourceCodesCollectionHandler::class,
LpasResourceCodesCollectionHandler::class,
'lpa.get.codes'
);
$app->put(
'/v1/lpas/{user-lpa-actor-token:[0-9a-f\-]+}/codes',
App\Handler\LpasResourceCodesCollectionHandler::class,
LpasResourceCodesCollectionHandler::class,
'lpa.cancel.code'
);
$app->get(
'/v1/lpas/{user-lpa-actor-token:[0-9a-f\-]+}/images',
App\Handler\LpasResourceImagesCollectionHandler::class,
LpasResourceImagesCollectionHandler::class,
'lpa.get.images'
);

$app->post('/v1/add-lpa/validate', App\Handler\AddLpaValidationHandler::class, 'lpa.add.validate');
$app->post('/v1/add-lpa/confirm', App\Handler\AddLpaConfirmationHandler::class, 'lpa.add.confirm');
$app->post('/v1/add-lpa/validate', AddLpaValidationHandler::class, 'lpa.add.validate');
$app->post('/v1/add-lpa/confirm', AddLpaConfirmationHandler::class, 'lpa.add.confirm');

$app->post('/v1/viewer-codes/summary', App\Handler\ViewerCodeSummaryHandler::class, 'lpa.viewer-code.summary');
$app->post('/v1/viewer-codes/full', App\Handler\ViewerCodeFullHandler::class, 'lpa.viewer-code.full');
$app->post('/v1/viewer-codes/summary', ViewerCodeSummaryHandler::class, 'lpa.viewer-code.summary');
$app->post('/v1/viewer-codes/full', ViewerCodeFullHandler::class, 'lpa.viewer-code.full');

$app->get('/v1/user', App\Handler\UserHandler::class, 'user.get');
$app->post('/v1/user', App\Handler\UserHandler::class, 'user.create');
$app->patch('/v1/user-activation', App\Handler\UserActivateHandler::class, 'user.activate');
$app->get('/v1/user', UserHandler::class, 'user.get');
$app->post('/v1/user', UserHandler::class, 'user.create');
$app->patch('/v1/user-activation', UserActivateHandler::class, 'user.activate');

$app->patch('/v1/request-password-reset', App\Handler\RequestPasswordResetHandler::class, 'user.password-reset');
$app->get('/v1/can-password-reset', App\Handler\CanPasswordResetHandler::class, 'user.can-password-reset');
$app->patch('/v1/request-password-reset', RequestPasswordResetHandler::class, 'user.password-reset');
$app->get('/v1/can-password-reset', CanPasswordResetHandler::class, 'user.can-password-reset');
$app->patch(
'/v1/complete-password-reset',
App\Handler\CompletePasswordResetHandler::class,
CompletePasswordResetHandler::class,
'user.complete-password-reset'
);

$app->patch('/v1/request-change-email', App\Handler\RequestChangeEmailHandler::class, 'user.request-change-email');
$app->get('/v1/can-reset-email', App\Handler\CanResetEmailHandler::class, 'user.can-reset-email');
$app->patch('/v1/request-change-email', RequestChangeEmailHandler::class, 'user.request-change-email');
$app->get('/v1/can-reset-email', CanResetEmailHandler::class, 'user.can-reset-email');
$app->patch(
'/v1/complete-change-email',
App\Handler\CompleteChangeEmailHandler::class,
CompleteChangeEmailHandler::class,
'user.complete-change-email'
);
$app->patch('/v1/change-password', App\Handler\ChangePasswordHandler::class, 'user.change-password');
$app->patch('/v1/change-password', ChangePasswordHandler::class, 'user.change-password');
$app->delete(
'/v1/delete-account/{account-id:[0-9a-f\-]+}',
App\Handler\CompleteDeleteAccountHandler::class,
CompleteDeleteAccountHandler::class,
'user.delete-account'
);

$app->patch('/v1/auth', App\Handler\AuthHandler::class, 'user.auth');
$app->patch('/v1/auth', AuthHandler::class, 'user.auth');

$app->post('/v1/email-user/{emailTemplate}', App\Handler\NotifyHandler::class, 'lpa.user.notify');
$app->get('/v1/auth-one-login', AuthRedirectHandler::class, 'user.auth-one-login');

$app->post('/v1/email-user/{emailTemplate}', NotifyHandler::class, 'lpa.user.notify');
};
10 changes: 7 additions & 3 deletions service-api/app/src/App/src/Service/Authentication/AuthenticationService.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use Facile\OpenIDClient\Client\ClientBuilder;
use Facile\OpenIDClient\Client\Metadata\ClientMetadata;
use Facile\OpenIDClient\Issuer\IssuerBuilder;
use Facile\OpenIDClient\Issuer\IssuerBuilderInterface;
use Facile\OpenIDClient\Service\Builder\AuthorizationServiceBuilder;
use Psr\Log\InvalidArgumentException;
use Psr\Log\LoggerInterface;
Expand All @@ -15,15 +16,18 @@

class AuthenticationService
{
public function __construct(private JWKFactory $JWKFactory, private LoggerInterface $logger)
{
public function __construct(
private JWKFactory $JWKFactory,
private LoggerInterface $logger,
private IssuerBuilderInterface $issuerBuilder,
) {
}

public function redirect(string $uiLocale): string
{
//TODO UML-3080 Configure cache

$issuer = (new IssuerBuilder())
$issuer = $this->issuerBuilder
->build('http://mock-one-login:8080/.well-known/openid-configuration');


Expand Down
26 changes: 21 additions & 5 deletions service-api/app/test/AppTest/Service/Authentication/AuthenticationServiceTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@

use App\Service\Authentication\AuthenticationService;
use App\Service\Authentication\JWKFactory;
use Facile\OpenIDClient\Issuer\IssuerBuilder;
use Facile\OpenIDClient\Issuer\IssuerBuilderInterface;
use Facile\OpenIDClient\Issuer\IssuerInterface;
use Facile\OpenIDClient\Issuer\Metadata\IssuerMetadataInterface;
use Jose\Component\Core\JWK;
use PHPUnit\Framework\TestCase;
use Prophecy\PhpUnit\ProphecyTrait;
Expand All @@ -18,21 +22,33 @@ class AuthenticationServiceTest extends TestCase

private ObjectProphecy|JWKFactory $JWKFactory;
private ObjectProphecy|LoggerInterface $logger;
private ObjectProphecy|IssuerBuilder $issuerBuilder;

public function setup(): void
{
$jwk = $this->prophesize(JWK::class);
$this->JWKFactory = $this->prophesize(JWKFactory::class);
$jwk = $this->prophesize(JWK::class);
$this->JWKFactory = $this->prophesize(JWKFactory::class);
$this->logger = $this->prophesize(LoggerInterface::class);
$this->issuerBuilder = $this->prophesize(IssuerBuilderInterface::class);
$issuer = $this->prophesize(IssuerInterface::class);
$issuerMetaData = $this->prophesize(IssuerMetadataInterface::class);

$this->JWKFactory->__invoke()->willReturn($jwk);
$this->logger = $this->prophesize(LoggerInterface::class);
$issuer->getMetadata()->willReturn($issuerMetaData);
$issuerMetaData->getAuthorizationEndpoint()->willReturn('fake endpoint');
$this->issuerBuilder->build('http://mock-one-login:8080/.well-known/openid-configuration')->willReturn($issuer);
}

/**
* @test
*/
public function get_redirect_uri_en(): void
public function get_redirect_uri(): void
{
$authenticationService = new AuthenticationService($this->JWKFactory->reveal(), $this->logger->reveal());
$authenticationService = new AuthenticationService(
$this->JWKFactory->reveal(),
$this->logger->reveal(),
$this->issuerBuilder->reveal()
);
$redirectUri = $authenticationService->redirect('en');
$this->assertStringContainsString('client_id=client-id', $redirectUri);
$this->assertStringContainsString('scope=openid+email', $redirectUri);
Expand Down

0 comments on commit 8027ab4

Please sign in to comment.