replace testableAbstractHandler with an anoymous class

ministryofjustice · Dec 8, 2023 · f16a444 · f16a444
1 parent c8700af
commit f16a444
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 20 deletions.
diff --git a/service-front/app/test/CommonTest/Handler/AbstractHandlerTest.php b/service-front/app/test/CommonTest/Handler/AbstractHandlerTest.php
@@ -4,13 +4,15 @@
 
 namespace CommonTest\Handler;
 
-use CommonTest\Handler\TestableAbstractHandler;
+use Common\Handler\AbstractHandler;
 use Mezzio\Helper\UrlHelper;
 use Mezzio\Template\TemplateRendererInterface;
 use PHPUnit\Framework\TestCase;
 use Prophecy\Argument;
 use Prophecy\PhpUnit\ProphecyTrait;
 use Prophecy\Prophecy\ObjectProphecy;
+use Psr\Http\Message\ResponseInterface;
+use Psr\Http\Message\ServerRequestInterface;
 
 class AbstractHandlerTest extends TestCase
 {
@@ -33,7 +35,12 @@ public function testRedirectToRouteWithOverride(): void
 
         $renderer = $this->prophesize(TemplateRendererInterface::class);
 
-        $abstractHandler = new TestableAbstractHandler($renderer->reveal(), $urlHelperMock->reveal());
+        $abstractHandler = new class ($renderer->reveal(), $urlHelperMock->reveal()) extends AbstractHandler {
+            public function handle(ServerRequestInterface $request): ResponseInterface
+            {
+                throw new Exception('Not implemented');
+            }
+        };
         $response        = $abstractHandler->redirectToRoute(
             'fake-route',
             ['fake-route-parameters'],
@@ -55,7 +62,12 @@ public function testRedirectToRouteOverrideSetToNull(): void
 
         $renderer = $this->prophesize(TemplateRendererInterface::class);
 
-        $abstractHandler = new TestableAbstractHandler($renderer->reveal(), $urlHelperMock->reveal());
+        $abstractHandler = new class($renderer->reveal(), $urlHelperMock->reveal()) extends AbstractHandler {
+            public function handle(ServerRequestInterface $request): ResponseInterface
+            {
+                throw new Exception('Not implemented');
+            }
+        };
         $response        = $abstractHandler->redirectToRoute('fake-route');
         $this->assertEquals('/fake-route', $response->getHeader('location')[0]);
     }

diff --git a/service-front/app/test/CommonTest/Handler/TestableAbstractHandler.php b/service-front/app/test/CommonTest/Handler/TestableAbstractHandler.php