Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3076 Factory to provide JWK for OIDC flow #2353

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

MishNajam
Copy link
Contributor

@MishNajam MishNajam commented Sep 25, 2023

Purpose

Factory class that returns a configured JWK using jwt-signature-algorithm-ecdsa library createFromKey method. May need further configuration in UML-3056 potentially.

Fixes UML-3076

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@MishNajam MishNajam requested a review from a team as a code owner September 25, 2023 14:28
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #2353 (b75a2db) into main (a7bb3ae) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2353      +/-   ##
============================================
+ Coverage     91.95%   91.96%   +0.01%     
- Complexity     1453     1455       +2     
============================================
  Files           273      274       +1     
  Lines          6586     6597      +11     
============================================
+ Hits           6056     6067      +11     
  Misses          513      513              
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 88.81% <ø> (ø)
use-an-lpa-api 96.77% <100.00%> (+0.02%) ⬆️
use-an-lpa-front 89.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../src/App/src/Service/Authentication/JWKFactory.php 100.00% <100.00%> (ø)

@MishNajam MishNajam merged commit e727f8b into main Oct 2, 2023
29 checks passed
@MishNajam MishNajam deleted the UML-3076-Factory-to-provide-a-jwk-for-the-OIDC-flow branch October 2, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants