Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3109 Remove build_admin feature flag from TF #2362

Merged
merged 1 commit into from
Oct 9, 2023
Merged

UML-3109 Remove build_admin feature flag from TF #2362

merged 1 commit into from
Oct 9, 2023

Conversation

ntse
Copy link
Contributor

@ntse ntse commented Oct 6, 2023

Purpose

Simplify the Terraform case by removing a now unnecessary ternary.

Fixes UML-3109

Approach

Remove the build_admin flag as it exists in all environments. Use moved resources to refactor the code.

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@ntse ntse requested a review from a team as a code owner October 6, 2023 10:33
@ntse ntse merged commit 2a124d5 into main Oct 9, 2023
21 checks passed
@ntse ntse deleted the UML-3109 branch October 9, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants