Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3115 Move ECS Terraform to region module #2364

Merged
merged 7 commits into from
Oct 11, 2023
Merged

UML-3115 Move ECS Terraform to region module #2364

merged 7 commits into from
Oct 11, 2023

Conversation

ntse
Copy link
Contributor

@ntse ntse commented Oct 11, 2023

Purpose

Move all ECS-related Terraform resources to the region module in as part of the work to allow for multi-region deployments.

Fixes UML-3115

Approach

Move all of the ECS-related code and use temporary variables to pass in identifiers of resources created outside of the region module (e.g. loadbalancers). Create a refactor.tf file to update Terraform state.

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@ntse ntse requested a review from a team as a code owner October 11, 2023 09:15
Copy link
Contributor

@andrewpearce-digital andrewpearce-digital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might be an issue with the way providers are defined and passed in. Specifying a region provider, and passing in an unspecified management provider might result in the management provider being used wherever you have not told a resource what provider to use.

Also could use a fmt

@ntse ntse force-pushed the UML-3115 branch 3 times, most recently from 384101a to 4e857b2 Compare October 11, 2023 12:16
@ntse ntse merged commit db36d37 into main Oct 11, 2023
28 checks passed
@ntse ntse deleted the UML-3115 branch October 11, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants