Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3114 Use global DynamoDB tables #2365

Merged
merged 5 commits into from
Oct 16, 2023
Merged

UML-3114 Use global DynamoDB tables #2365

merged 5 commits into from
Oct 16, 2023

Conversation

ntse
Copy link
Contributor

@ntse ntse commented Oct 11, 2023

Purpose

Use Global DynamoDB tables

Fixes UML-3114

Approach

Enable streaming on the DynamoDB and create a replica for each non-primary region.

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@ntse ntse requested a review from a team as a code owner October 11, 2023 15:41
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #2365 (0616615) into main (8b2e943) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 0616615 differs from pull request most recent head 1974a36. Consider uploading reports for the commit 1974a36 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2365      +/-   ##
============================================
+ Coverage     91.96%   92.00%   +0.03%     
- Complexity     1455     1457       +2     
============================================
  Files           274      275       +1     
  Lines          6597     6629      +32     
============================================
+ Hits           6067     6099      +32     
  Misses          513      513              
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 88.81% <ø> (ø)
use-an-lpa-api 96.81% <ø> (+0.04%) ⬆️
use-an-lpa-front 89.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Contributor

@andrewpearce-digital andrewpearce-digital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could go a stage further and move the tables into the region module, but I might be missing context with resources not changed in this PR

@ntse ntse merged commit e617e18 into main Oct 16, 2023
22 checks passed
@ntse ntse deleted the UML-3114 branch October 16, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants