Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3137 Move DNS to region #2376

Merged
merged 5 commits into from
Oct 31, 2023
Merged

UML-3137 Move DNS to region #2376

merged 5 commits into from
Oct 31, 2023

Conversation

ntse
Copy link
Contributor

@ntse ntse commented Oct 19, 2023

Purpose

Briefly describe the purpose of the change, and/or link to the JIRA ticket for context

Fixes UML-####

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@ntse ntse marked this pull request as ready for review October 19, 2023 13:04
@ntse ntse requested a review from a team as a code owner October 19, 2023 13:04
@ntse ntse force-pushed the UML-3137 branch 3 times, most recently from 707578e to 442baf8 Compare October 26, 2023 11:46
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #2376 (db0cb32) into main (5ae1593) will decrease coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head db0cb32 differs from pull request most recent head b9dfd18. Consider uploading reports for the commit b9dfd18 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2376      +/-   ##
============================================
- Coverage     92.03%   91.96%   -0.08%     
+ Complexity     1463     1455       -8     
============================================
  Files           279      274       -5     
  Lines          6655     6597      -58     
============================================
- Hits           6125     6067      -58     
  Misses          513      513              
  Partials         17       17              

see 5 files with indirect coverage changes

jamesrwarren
jamesrwarren previously approved these changes Oct 30, 2023
@ntse ntse merged commit e12338d into main Oct 31, 2023
23 checks passed
@ntse ntse deleted the UML-3137 branch October 31, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants