UML-3138 Move TF account to region #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| resource "aws_kms_key" "cloudwatch" { | ||
| description = "Cloudwatch encryption ${local.environment}" | ||
| description = "Cloudwatch encryption ${var.environment_name}" |
There was a problem hiding this comment.
this could be the multi region kms key module
| kms_key_id = module.secrets_manager_mrk.key_id | ||
|
|
||
| replica { | ||
| kms_key_id = module.secrets_manager_mrk.key_id |
There was a problem hiding this comment.
I think this needs to be the id of the key in the region of the replicated secret, so the id of the replicated/secondary kms key.
This would have an affect if you needed to reference the key ARN (which has the region)
There was a problem hiding this comment.
Related multi-Region keys have the same key ID. Happy to change if it will reduce ambiguity
added 8 commits
October 25, 2023 10:32
andrewpearce-digital
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Move account resources into region
Fixes UML-3138
Approach
Explain how your code addresses the purpose of the change
Learning
Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service
Checklist