UML-3132 service api one login dummy endpoint returns a user #2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cooperaj
reviewed
Nov 3, 2023
service-api/app/config/routes.php
Outdated
| @@ -136,6 +137,7 @@ | |||
| $app->patch('/v1/auth', AuthHandler::class, 'user.auth'); | |||
|
|
|||
| $app->get('/v1/auth-one-login', OneLoginAuthenticationRequestHandler::class, 'user.auth-one-login'); | |||
There was a problem hiding this comment.
I think we should use /v1/auth/start and /v1/auth/callback
cooperaj
reviewed
Nov 3, 2023
service-api/app/config/routes.php
Outdated
| @@ -30,6 +30,7 @@ | |||
| use Mezzio\MiddlewareFactory; | |||
| use Psr\Container\ContainerInterface; | |||
| use App\Handler\OneLoginAuthenticationRequestHandler; | |||
| use App\Handler\OneLoginAuthorisationProcessHandler; | |||
There was a problem hiding this comment.
Suggested change
| use App\Handler\OneLoginAuthorisationProcessHandler; | |
| use App\Handler\OneLoginAuthenticationCallbackHandler; |
Codecov Report
@@ Coverage Diff @@
## main #2398 +/- ##
=========================================
Coverage 92.03% 92.03%
Complexity 1463 1463
=========================================
Files 279 279
Lines 6656 6656
=========================================
Hits 6126 6126
Misses 513 513
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cooperaj
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Creates a simple handler that returns a user object on service-api for one login.
Fixes UML-3132
Checklist