Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpcbf service-front/app #2401

Merged
merged 8 commits into from
Nov 7, 2023
Merged

Conversation

Lbagg1
Copy link
Contributor

@Lbagg1 Lbagg1 commented Nov 7, 2023

Purpose

Run phpcbf (phpcs fixer) to fix code in service-front . Ensure everything still works.

Fixes UML-2906

Approach

phpcbf has run on service-front/app/src and service-front/app/public. I have fixed errors manually with phpcs.

Learning

Checklist

  • I have performed a self-review of my own code
    * [ ] I have added relevant logging with appropriate levels to my code
    * [ ] New event_codes have been documented on the [wiki page] (https://opgtransform.atlassian.net/wiki/spaces/LSML2/pages/3277881441/Understanding+the+event+logs)
    * [ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
    * [ ] I have added tests to prove my work
    * [ ] I have added welsh translation tags and updated translation files
    * [ ] I have run an accessibility tool on any pages I have made changes to and fixed any issues found
    * [ ] I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
    * [ ] The product team have tested these changes

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #2401 (c96f2d2) into main (2106624) will decrease coverage by 0.23%.
The diff coverage is 32.25%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2401      +/-   ##
============================================
- Coverage     92.03%   91.81%   -0.23%     
  Complexity     1463     1463              
============================================
  Files           279      279              
  Lines          6656     6672      +16     
============================================
  Hits           6126     6126              
- Misses          513      529      +16     
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 88.81% <ø> (ø)
use-an-lpa-api 96.84% <ø> (+0.06%) ⬆️
use-an-lpa-front 88.80% <32.25%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ervice-front/app/src/Actor/src/Form/CancelCode.php 0.00% <ø> (ø)
...rvice-front/app/src/Actor/src/Form/ChangeEmail.php 100.00% <ø> (ø)
...ice-front/app/src/Actor/src/Form/CreateAccount.php 100.00% <ø> (ø)
...e-front/app/src/Actor/src/Form/CreateShareCode.php 0.00% <ø> (ø)
service-front/app/src/Actor/src/Form/Login.php 100.00% <ø> (ø)
...ervice-front/app/src/Actor/src/Form/LpaConfirm.php 0.00% <ø> (ø)
...ce-front/app/src/Actor/src/Form/PasswordChange.php 100.00% <ø> (ø)
...ice-front/app/src/Actor/src/Form/PasswordReset.php 100.00% <ø> (ø)
.../Actor/src/Form/RequestActivationKey/ActorRole.php 100.00% <100.00%> (ø)
service-front/app/src/Actor/src/Form/Triage.php 100.00% <ø> (ø)
... and 14 more

@Lbagg1 Lbagg1 marked this pull request as ready for review November 7, 2023 13:04
@Lbagg1 Lbagg1 requested a review from a team as a code owner November 7, 2023 13:04
@Lbagg1 Lbagg1 merged commit 69d1896 into main Nov 7, 2023
30 of 31 checks passed
@Lbagg1 Lbagg1 deleted the uml2906-phpcbf-service-front-src-actor branch November 7, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants