Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpcbf test/AppTest/Service #2430

Merged
merged 7 commits into from
Nov 21, 2023
Merged

Conversation

Lbagg1
Copy link
Contributor

@Lbagg1 Lbagg1 commented Nov 15, 2023

Purpose

Run phpcbf (phpcs fixer) to fix code in service-api. Ensure everything still works.

Fixes UML-2907

Approach

Learning

Checklist

  • I have performed a self-review of my own code
  • [ ] I have added relevant logging with appropriate levels to my code
  • [ ] New event_codes have been documented on the [wiki page](https://opgtransform.atlassian.net/wiki/spaces/LSML2/pages/3277881441/Understanding+the+event+logs)~
  • [ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • [ ] I have added tests to prove my work
  • [ ] I have added welsh translation tags and updated translation files
  • [ ] I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • [ ] I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • [ ] The product team have tested these changes

@Lbagg1 Lbagg1 marked this pull request as ready for review November 21, 2023 09:19
@Lbagg1 Lbagg1 requested a review from a team as a code owner November 21, 2023 09:19
@Lbagg1 Lbagg1 merged commit 3483250 into main Nov 21, 2023
31 checks passed
@Lbagg1 Lbagg1 deleted the uml-2907-Phpcbf-to-fix-code-in-service-api-5 branch November 21, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants