Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uml-2976 Remove "important" on dashboard #2432

Closed
wants to merge 3 commits into from
Closed

uml-2976 Remove "important" on dashboard #2432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a6abd9
removed important message
Lbagg1 Nov 15, 2023
276d099
removed behat test
Lbagg1 Nov 15, 2023
6497849
update behat tests
Lbagg1 Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions service-front/app/features/actor-dashboard.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ Feature: The user is able to see correct information on their dashboard
Given I am on the dashboard page
Then I can see that no organisations have access to my LPA

@ui
Scenario: As a user I can see the message on instructions and preferences
Given I am on the dashboard page
Then I can see the message Important: This LPA has instructions and preferences.

@ui
Scenario: As a user I can see the read more link in the message on instructions and preferences
Expand Down
6 changes: 1 addition & 5 deletions service-front/app/features/context/UI/LpaContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,16 +695,12 @@ public function iCanSeeBannerAboutExistingLPAsAfter2016(): void
}

/**
* @Then /^I can see (.*) link along with the instructions or preference message$/
* @Then /^I can see (.*)
*/
public function iCanSeeReadMoreLink($readMoreLink): void
{
$this->ui->assertPageAddress('/lpa/dashboard');

$this->ui->assertPageContainsText(
'Important: This LPA has instructions and preferences. '
);

$session = $this->ui->getSession();
$page = $session->getPage();

Expand Down
2 changes: 0 additions & 2 deletions service-front/app/src/Actor/templates/actor/partials/lpa-details.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
<a class="govuk-link" href="{{ path('lpa.removed') }}"> {% trans %}Why is this?{% endtrans %}</a>
</p>
{% endif %}

{{ include('@actor/partials/lpa-instructions-preferences-important-message.html.twig') }}
</div>

<div class="lpa-status">
Expand Down
Loading