Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-2912 Get local https working. #2453

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Conversation

cooperaj
Copy link
Contributor

@cooperaj cooperaj commented Dec 5, 2023

Purpose

Fix https running for local dev. At the moment we have certificate problems due to lack of local https running. In Make an extra container is run to take care of this, however that may have downsides. This story is to find a simple solution that works for everyone.

Fixes UML-2912

Approach

Using a Traefik proxy container to proxy existing ports to the services with the addition of self-signed HTTPS ports being made available and redirected to as we currently do at the AWS LB level.

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@cooperaj cooperaj requested a review from a team as a code owner December 5, 2023 17:53
ntse
ntse previously approved these changes Dec 6, 2023
ntse
ntse previously approved these changes Dec 7, 2023
gregtyler
gregtyler previously approved these changes Dec 7, 2023
Copy link
Contributor

@gregtyler gregtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well for me 🎉

Might be worth changing the default protocol/port in the readme to push people onto HTTPS, though the redirect's great

@nickdavis2001 nickdavis2001 dismissed stale reviews from gregtyler and ntse via ab3da30 December 7, 2023 14:19
@cooperaj cooperaj changed the title Get local https working. UML-2912 Get local https working. Dec 11, 2023
@cooperaj cooperaj merged commit 3925d88 into main Dec 11, 2023
31 checks passed
@cooperaj cooperaj deleted the uml-2912-make-https-work-locally branch December 11, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants