-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uml 1533 hashing logged email #2460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2460 +/- ##
============================================
+ Coverage 91.94% 92.03% +0.09%
- Complexity 1467 1468 +1
============================================
Files 279 279
Lines 6655 6657 +2
============================================
+ Hits 6119 6127 +8
+ Misses 519 513 -6
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattmachell
reviewed
Dec 14, 2023
cooperaj
requested changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good bar the .idea folder 👍
cooperaj
previously approved these changes
Dec 18, 2023
cooperaj
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Currently we hash email addresses that we are logging to protect PII from being leaked.
There are 2 places where we have missed this:
UserService.php (front) line 135
$this->logger->notice(
'Authentication failed for {email} with code
[
'code' => $e->getCode(),
'email' => $email
]
);
UserService.php (api) line 200
$this->logger->notice(
'Attempt made to reset password for non-existent account',
['email' => $email]
);
AC
The email is hashed in these places where we have missed it
Search code base for other missed examples and fix
Including MLPA - LPAL-1264: Hash PII when logging password reset requests
BACKLOG
Fixes UML-1533
Checklist
[ ] I have added relevant logging with appropriate levels to my code[ ] New event_codes have been documented on the wiki page*~ [ ] I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant~
[ ] I have added welsh translation tags and updated translation files*~ [ ] I have run an accessibility tool on any pages I have made changes to and fixed any issues found~
[ ] I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made