Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3108 Two region environment #2486

Merged
merged 27 commits into from
Jan 12, 2024
Merged

UML-3108 Two region environment #2486

merged 27 commits into from
Jan 12, 2024

Conversation

ntse
Copy link
Contributor

@ntse ntse commented Jan 4, 2024

Purpose

Changes to codebase to allow the service to be deployed to multiple regions.

Fixes UML-3108

Approach

After testing deploying a secondary region to development, changes needed to be made to fix the various errors.

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7dd3014) 92.11% compared to head (a21b3e6) 92.08%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2486      +/-   ##
============================================
- Coverage     92.11%   92.08%   -0.03%     
+ Complexity     1510     1503       -7     
============================================
  Files           294      291       -3     
  Lines          6848     6824      -24     
============================================
- Hits           6308     6284      -24     
  Misses          523      523              
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 88.81% <ø> (ø)
use-an-lpa-api 96.85% <100.00%> (+0.19%) ⬆️
use-an-lpa-front 89.21% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ss/ApiGateway/InstructionsAndPreferencesImages.php 100.00% <ø> (ø)
...src/DataAccess/ApiGateway/RequestSignerFactory.php 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@ntse ntse changed the title [DO NOT MERGE] UML-3108 Two region environment UML-3108 Two region environment Jan 10, 2024
@ntse ntse marked this pull request as ready for review January 11, 2024 09:21
@ntse ntse requested a review from a team as a code owner January 11, 2024 09:21
@ntse ntse force-pushed the UML-3108 branch 3 times, most recently from 406ae41 to bfbbe41 Compare January 11, 2024 15:58
@ntse ntse merged commit 5f13664 into main Jan 12, 2024
34 checks passed
@ntse ntse deleted the UML-3108 branch January 12, 2024 09:32
jay-whitwell pushed a commit that referenced this pull request Jan 17, 2024
* UML-3108 Enable option for two regions in environment Terraform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants