Uml 3459 return sirius data via new endpoint in new format #2770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-endpoint-in-new-format
…heritance for the entities to help structure datastore and for future sirius implementation
…-endpoint-in-new-format
…-endpoint-in-new-format
created new files for dedicated tests
…-endpoint-in-new-format
…n-new-format' into UML-3459-return-sirius-data-via-new-endpoint-in-new-format
…tests, and removed unused imports
…-endpoint-in-new-format # Conflicts: # service-api/app/test/AppTest/Service/Lpa/LpaServiceTest.php
…n-new-format' into UML-3459-return-sirius-data-via-new-endpoint-in-new-format # Conflicts: # service-api/app/src/App/src/Service/Lpa/LpaDataFormatter.php
github-actions
bot
added
dependencies
allenannom
changed the base branch from
main
to
UML-3460-return-lpa-store-via-new-endpoint-in-new-format
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2770 +/- ##
============================================
+ Coverage 91.25% 91.52% +0.27%
- Complexity 1504 1570 +66
============================================
Files 309 344 +35
Lines 6393 6657 +264
============================================
+ Hits 5834 6093 +259
- Misses 542 547 +5
Partials 17 17
|
…-endpoint-in-new-format
…n-new-format' into UML-3459-return-sirius-data-via-new-endpoint-in-new-format
Base automatically changed from
UML-3460-return-lpa-store-via-new-endpoint-in-new-format
to
main
September 11, 2024 08:25
…ew-endpoint-in-new-format # Conflicts: # service-api/app/src/App/src/Enum/LifeSustainingTreatment.php # service-api/app/src/App/src/Service/Lpa/LpaDataFormatter.php
cooperaj
reviewed
Sep 12, 2024
cooperaj
reviewed
Sep 17, 2024
service-api/app/test/AppTest/Entity/CanSerialiseSiriusToModerniseFormatTest.php
Outdated
Show resolved
Hide resolved
…iseFormatTest.php Co-authored-by: Adam Cooper <[email protected]>
cooperaj
reviewed
Sep 20, 2024
| ), | ||
| $lpaObject = $this->hydrateObject($lpa); | ||
|
|
||
| return $this->mapper->serializeObject( |
There was a problem hiding this comment.
We need this to return the hydrated object for use in our service classes.
The serialisation part will happen just before we return so we'll want to ensure that either a) the objects themselves can use their own mapper via a jsonSerialize method or b) a service is available to be called. I personally would go with a)
There was a problem hiding this comment.
In fact. I'm going to approve this but the above work will need to be done before the combined stuff starts to happen.
cooperaj
approved these changes
Sep 20, 2024
allenannom
deleted the
UML-3459-return-sirius-data-via-new-endpoint-in-new-format
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Returning Sirius LPAs via the new endpoint in the new format
Learning
The use of a new library to map incoming data store LPA array using https://github.com/EventSaucePHP/ObjectHydrator
Checklist