Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type coersion to SiriusPerson getters #2817

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

gregtyler
Copy link
Contributor

Purpose

To ensure that the returned value matches the type specified in the method definition.

Fixes UML-3657 #patch

Approach

Used PHP's inline type casting

Learning

Check the logs first 😄 Though running locally was useful to ensure it would fix the underlying issue

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@gregtyler gregtyler requested a review from a team as a code owner September 27, 2024 14:02
@github-actions github-actions bot added php Pull requests that update Php code service-api labels Sep 27, 2024
mattmachell
mattmachell previously approved these changes Sep 27, 2024
To ensure that the returned value matches the type specified in the method definition.

Fixes UML-3657 #patch
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.48%. Comparing base (f00760a) to head (2f240b2).
Report is 48 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2817      +/-   ##
============================================
+ Coverage     91.25%   91.48%   +0.23%     
- Complexity     1504     1587      +83     
============================================
  Files           309      345      +36     
  Lines          6393     6695     +302     
============================================
+ Hits           5834     6125     +291     
- Misses          542      553      +11     
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 79.26% <ø> (ø)
use-an-lpa-api 97.47% <100.00%> (+0.10%) ⬆️
use-an-lpa-front 89.35% <ø> (-0.19%) ⬇️
Files with missing lines Coverage Δ
...e-api/app/src/App/src/Service/Lpa/SiriusPerson.php 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@gregtyler gregtyler merged commit 495bceb into main Sep 27, 2024
34 checks passed
@gregtyler gregtyler deleted the UML-2657-siriusperson-type-coersion branch September 27, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
php Pull requests that update Php code service-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants