UML-3671 rework find actor lpa

[nickdavis2001]

Purpose

Rework findActorInLpa to use combined format

Approach

Make findActorInLpa be able to take GetAttorneyStatus interface as an arg, while for now continuing to support existing interim SiriusLpa. Move GetAttorneyStatus onto Person to enable that to happen. Extensive refactor of unit tests including adding fixture methods, to make them manageable. Replicate unit tests for combined format alongside interim format

Checklist

• I have performed a self-review of my own code
• I have added relevant logging with appropriate levels to my code
• New event_codes have been documented on the wiki page
• I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
• I have added tests to prove my work
• I have added welsh translation tags and updated translation files
• I have run an accessibility tool on any pages I have made changes to and fixed any issues found
• I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
• The product team have tested these changes

[codecov]

Codecov Report

Attention: Patch coverage is 95.02488% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.91%. Comparing base (f00760a) to head (ad503b5).
Report is 156 commits behind head on main.

Files with missing lines	Patch %	Lines
...e-api/app/src/App/src/Entity/LpaStore/LpaStore.php	50.00%	3 Missing ⚠️
...ce-api/app/src/App/src/Entity/Sirius/SiriusLpa.php	70.00%	3 Missing ⚠️
...i/app/src/App/src/Entity/Sirius/SiriusLpaDonor.php	75.00%	2 Missing ⚠️
...e-api/app/src/App/src/Service/Lpa/SiriusPerson.php	77.77%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2878      +/-   ##
============================================
+ Coverage     91.25%   91.91%   +0.65%     
- Complexity     1504     1740     +236     
============================================
  Files           309      379      +70     
  Lines          6393     8283    +1890     
============================================
+ Hits           5834     7613    +1779     
- Misses          542      653     +111     
  Partials         17       17              

Flag	Coverage Δ
use-an-lpa-admin	78.68% <ø> (-0.58%)	⬇️
use-an-lpa-api	97.22% <95.02%> (-0.15%)	⬇️
use-an-lpa-front	90.82% <ø> (+1.28%)	⬆️

Files with missing lines	Coverage Δ
service-api/app/src/App/src/Entity/Lpa.php	100.00% <100.00%> (ø)
...p/src/App/src/Entity/LpaStore/LpaStoreAttorney.php	100.00% <ø> (ø)
.../app/src/App/src/Entity/LpaStore/LpaStoreDonor.php	100.00% <ø> (ø)
...p/src/Entity/LpaStore/LpaStoreTrustCorporation.php	100.00% <ø> (ø)
service-api/app/src/App/src/Entity/Person.php	100.00% <100.00%> (ø)
...pp/src/Entity/Sirius/Casters/LinkedDonorCaster.php	100.00% <100.00%> (ø)
...pp/src/App/src/Entity/Sirius/SiriusLpaAttorney.php	100.00% <100.00%> (ø)
...pp/src/Entity/Sirius/SiriusLpaTrustCorporation.php	100.00% <100.00%> (ø)
...ervice/Lpa/AccessForAll/AccessForAllValidation.php	100.00% <100.00%> (ø)
...rc/Service/Lpa/AccessForAll/AddAccessForAllLpa.php	100.00% <100.00%> (ø)
... and 13 more

... and 189 files with indirect coverage changes

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[allenannom]

amazing!

[cooperaj]

This fail in a combined world