Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3136: Update viewer journey templates to support combined LPAs #2903

Merged
merged 34 commits into from
Nov 27, 2024

Conversation

acsauk
Copy link
Contributor

@acsauk acsauk commented Nov 4, 2024

Purpose

So, this was a bit of a slog, but from testing the viewer journey for the current LPA format, combined Sirius, and combined LPA-store LPAs, it looks like it's working.

I went with new templates to support the combined LPA rather than adding logic to existing templates as this felt a bit cleaner and should hopefully have less cleanup in the future.

I made an attempt to start the API work that would be required to support this once the mock API response is removed but the PR was already getting huge so I moved it to its own branch. Feel free to disregard if the API work isn't picked up for a while as it will quickly be outdated.

I ran out of time before I could add behat tests but it may be worth waiting to implement them when the data model has solidified and the API side has been implemented.

I made a few additions to the front end unit tests such as using some test helpers rather than relying on JSON files to get an LPA instrumented and ready to test.

Hopefully, this all makes sense and I haven't made any rash assumptions on the format of things but shout up if you want to talk through any of the PR and we can jump on a call.

Fixes UML-3136

@github-actions github-actions bot added php Pull requests that update Php code docker Pull requests that update Docker code service-front labels Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 96.10390% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.78%. Comparing base (f00760a) to head (eaa64f1).
Report is 168 commits behind head on main.

Files with missing lines Patch % Lines
...ce-front/app/src/Common/src/Entity/CombinedLpa.php 90.90% 2 Missing ⚠️
service-front/app/src/Common/src/Entity/Person.php 92.85% 2 Missing ⚠️
...ervice-front/app/src/Common/src/Entity/Address.php 94.73% 1 Missing ⚠️
...src/Entity/Casters/ExtractPostcodeFromLpaStore.php 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2903      +/-   ##
============================================
+ Coverage     91.25%   91.78%   +0.53%     
- Complexity     1504     1765     +261     
============================================
  Files           309      383      +74     
  Lines          6393     8196    +1803     
============================================
+ Hits           5834     7523    +1689     
- Misses          542      656     +114     
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 78.85% <ø> (-0.41%) ⬇️
use-an-lpa-api 97.22% <ø> (-0.15%) ⬇️
use-an-lpa-front 90.53% <96.10%> (+0.99%) ⬆️
Files with missing lines Coverage Δ
...rc/Common/src/Entity/Casters/CastToCaseSubtype.php 100.00% <100.00%> (ø)
...Entity/Casters/CastToHowAttorneysMakeDecisions.php 100.00% <100.00%> (ø)
...c/Entity/Casters/CastToLifeSustainingTreatment.php 100.00% <100.00%> (ø)
...n/src/Entity/Casters/CastToWhenTheLpaCanBeUsed.php 100.00% <100.00%> (ø)
...nt/app/src/Common/src/Entity/LpaStore/LpaStore.php 100.00% <100.00%> (ø)
...rc/Common/src/Entity/LpaStore/LpaStoreAttorney.php 100.00% <100.00%> (ø)
...p/src/Common/src/Entity/LpaStore/LpaStoreDonor.php 100.00% <100.00%> (ø)
.../src/Entity/LpaStore/LpaStoreTrustCorporations.php 90.90% <100.00%> (ø)
...ont/app/src/Common/src/Entity/Sirius/SiriusLpa.php 100.00% <100.00%> (ø)
...src/Common/src/Entity/Sirius/SiriusLpaAttorney.php 100.00% <ø> (ø)
... and 15 more

... and 193 files with indirect coverage changes

@acsauk acsauk changed the title UML-3136: Update types to display viewer journey UML-3136: Update viewer journey templates to support combined LPAs Nov 6, 2024
@acsauk acsauk marked this pull request as ready for review November 12, 2024 22:00
@acsauk acsauk requested a review from a team as a code owner November 12, 2024 22:00
@cooperaj cooperaj merged commit 4f38b73 into main Nov 27, 2024
33 checks passed
@cooperaj cooperaj deleted the UML-3136-update-viewer-templates-combined-lpa branch November 27, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code php Pull requests that update Php code service-api service-front
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants