Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial stab at JS smoke test for use #2935

Merged
merged 5 commits into from
Dec 4, 2024
Merged

Initial stab at JS smoke test for use #2935

merged 5 commits into from
Dec 4, 2024

Conversation

mattmachell
Copy link
Contributor

@mattmachell mattmachell commented Nov 13, 2024 •
edited by jira bot
Loading

Testing if Mink can handle the JS loaded call.

Fixes UML-3716

@mattmachell mattmachell requested a review from a team as a code owner November 13, 2024 17:20
@github-actions github-actions bot added php Pull requests that update Php code javascript Pull requests that update Javascript code service-front labels Nov 13, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (f00760a) to head (2b3a914).
Report is 177 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2935      +/-   ##
============================================
+ Coverage     91.25%   91.91%   +0.65%     
- Complexity     1504     1779     +275     
============================================
  Files           309      389      +80     
  Lines          6393     8233    +1840     
============================================
+ Hits           5834     7567    +1733     
- Misses          542      649     +107     
  Partials         17       17
Flag Coverage Δ
use-an-lpa-admin 78.85% <ø> (-0.41%) ⬇️
use-an-lpa-api 97.28% <ø> (-0.09%) ⬇️
use-an-lpa-front 90.69% <ø> (+1.15%) ⬆️

see 200 files with indirect coverage changes

@mattmachell mattmachell force-pushed the js-smoke branch 2 times, most recently from f45f2af to e12e73c Compare November 18, 2024 10:40
cooperaj
cooperaj reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@cooperaj cooperaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some wording change but looks great

@mattmachell mattmachell merged commit b1398ac into main Dec 4, 2024
32 checks passed
@mattmachell mattmachell deleted the js-smoke branch December 4, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooperaj cooperaj cooperaj approved these changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code php Pull requests that update Php code service-front
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmachell @cooperaj