UML-3628 Request a key templates to work with combined format #2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2978 +/- ##
=========================================
Coverage 91.95% 91.95%
Complexity 1781 1781
=========================================
Files 390 390
Lines 8275 8276 +1
=========================================
+ Hits 7609 7610 +1
Misses 649 649
Partials 17 17
|
SeemaMenon
force-pushed
the
UML-3628-template-refactor
branch
from
b702290 to
59cddd0
Compare
github-actions
bot
added
terraform
allenannom
reviewed
Dec 9, 2024
docker-compose.yml
Outdated
| @@ -109,7 +109,7 @@ services: | |||
| ALLOW_MERIS_LPAS: "false" | |||
| INSTRUCTIONS_AND_PREFERENCES: "true" | |||
| ALLOW_GOV_ONE_LOGIN: "true" | |||
| SUPPORT_DATASTORE_LPAS: "false" | |||
| SUPPORT_DATASTORE_LPAS: "true" | |||
There was a problem hiding this comment.
this should be set to false as the feature isn't ready for production yet
There was a problem hiding this comment.
yes, I need a run to get the dev links for UAT. will revert after UAT
| @@ -62,7 +62,7 @@ | |||
| "allow_meris_lpas": false, | |||
| "instructions_and_preferences": true, | |||
| "allow_gov_one_login": true, | |||
| "support_datastore_lpas": false | |||
| "support_datastore_lpas": true | |||
There was a problem hiding this comment.
flag should be turned off here too
allenannom
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Refactoring request a key templates to work with combined LPA format
Fixes UML-3628
Approach
Explain how your code addresses the purpose of the change
Learning
Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service
Checklist