Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3750 added exception for null DOB #2984

Merged
merged 35 commits into from
Dec 19, 2024

Conversation

allenannom
Copy link
Contributor

@allenannom allenannom commented Dec 5, 2024

Purpose

Added an exception to be thrown when the DOB is null. Then implemented a try/catch with a warning log

Fixes UML-3750

Approach

appropriately outputs the known error and logs _

Checklist

  • I have performed a self-review of my own code
  • I have added relevant logging with appropriate levels to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@allenannom allenannom requested a review from a team as a code owner December 5, 2024 15:27
@github-actions github-actions bot added php Pull requests that update Php code service-api labels Dec 5, 2024
SeemaMenon
SeemaMenon previously approved these changes Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (f00760a) to head (2c10eb0).
Report is 204 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2984      +/-   ##
============================================
+ Coverage     91.25%   91.95%   +0.69%     
- Complexity     1504     1781     +277     
============================================
  Files           309      390      +81     
  Lines          6393     8275    +1882     
============================================
+ Hits           5834     7609    +1775     
- Misses          542      649     +107     
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 78.85% <ø> (-0.41%) ⬇️
use-an-lpa-api 97.31% <100.00%> (-0.06%) ⬇️
use-an-lpa-front 90.69% <ø> (+1.15%) ⬆️
Files with missing lines Coverage Δ
.../src/Exception/ActorDateOfBirthNotSetException.php 100.00% <100.00%> (ø)
...api/app/src/App/src/Service/Lpa/FindActorInLpa.php 100.00% <100.00%> (ø)
...e-api/app/src/App/src/Service/Lpa/SiriusPerson.php 96.07% <100.00%> (ø)

... and 224 files with indirect coverage changes

Copy link
Contributor

@cooperaj cooperaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be missing the test case in the patch I sent that covers an LPA continuing to match on good actors even if a null dob actor is included.

cooperaj
cooperaj previously approved these changes Dec 18, 2024
@cooperaj cooperaj requested a review from mattmachell December 18, 2024 16:58
mattmachell
mattmachell previously approved these changes Dec 19, 2024
@allenannom allenannom dismissed stale reviews from cooperaj and mattmachell via b156fc7 December 19, 2024 10:13
@allenannom allenannom merged commit 6b2ef66 into main Dec 19, 2024
34 checks passed
@allenannom allenannom deleted the UML-3750-unable-to-request-activation branch December 19, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
php Pull requests that update Php code service-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants