-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UML-3750 added exception for null DOB #2984
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2984 +/- ##
============================================
+ Coverage 91.25% 91.95% +0.69%
- Complexity 1504 1781 +277
============================================
Files 309 390 +81
Lines 6393 8275 +1882
============================================
+ Hits 5834 7609 +1775
- Misses 542 649 +107
Partials 17 17
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be missing the test case in the patch I sent that covers an LPA continuing to match on good actors even if a null dob actor is included.
…nistryofjustice/opg-use-an-lpa into UML-3750-unable-to-request-activation
b156fc7
Purpose
Added an exception to be thrown when the DOB is null. Then implemented a try/catch with a warning log
Fixes UML-3750
Approach
appropriately outputs the known error and logs _
Checklist