-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UML-3753 tech debt - remove no longer needed IaP flag #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2987 +/- ##
============================================
+ Coverage 91.25% 91.90% +0.65%
- Complexity 1504 1778 +274
============================================
Files 309 389 +80
Lines 6393 8232 +1839
============================================
+ Hits 5834 7566 +1732
- Misses 542 649 +107
Partials 17 17
|
cooperaj
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docker
Pull requests that update Docker code
php
Pull requests that update Php code
service-api
service-front
terraform
Pull requests that update Terraform code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove tech debt by removing references to IaP flag thus simplifying the code, update tests
Approach
_Remove logic around IaP feature flag in code and tests, remove 3 front scenarios that are flagged to run only with the flag turned off, and steps that are only called by a scenario that is getting removed, api side remove feature flag logic from tests. remove flag from terraform. _
Checklist