Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UML-3738: eventbridge & lambda permissions #3014

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Conversation

jay-whitwell
Copy link
Contributor

@jay-whitwell jay-whitwell commented Dec 18, 2024

Purpose

Adds permissions for the EventBus & SQS to communicate with Lambda

Fixes UML-3738

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service

Checklist (tick/delete or strikethrough as appropriate)

  • I have performed a self-review of my own code
  • I have added tests to prove my work
  • I have added relevant and appropriately leveled logging, without PII, to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc)
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@jay-whitwell jay-whitwell requested a review from a team as a code owner December 18, 2024 09:20
@github-actions github-actions bot added the terraform Pull requests that update Terraform code label Dec 18, 2024
@jay-whitwell jay-whitwell changed the title UML-3738 UML-3738: eventbridge & lambda permissions Dec 19, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (f00760a) to head (5921e22).
Report is 207 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3014      +/-   ##
============================================
+ Coverage     91.25%   91.95%   +0.69%     
- Complexity     1504     1781     +277     
============================================
  Files           309      390      +81     
  Lines          6393     8275    +1882     
============================================
+ Hits           5834     7609    +1775     
- Misses          542      649     +107     
  Partials         17       17              
Flag Coverage Δ
use-an-lpa-admin 78.85% <ø> (-0.41%) ⬇️
use-an-lpa-api 97.31% <ø> (-0.06%) ⬇️
use-an-lpa-front 90.69% <ø> (+1.15%) ⬆️

see 223 files with indirect coverage changes

@github-actions github-actions bot added the go Pull requests that update Go code label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions go Pull requests that update Go code terraform Pull requests that update Terraform code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant