Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UML-3808: allow api ecs access to secretsmanager #3101

Merged
merged 12 commits into from
Jan 29, 2025
Merged

UML-3808: allow api ecs access to secretsmanager #3101

merged 12 commits into from
Jan 29, 2025
+57 −6

Conversation

jay-whitwell
Copy link
Contributor

Purpose

Briefly describe the purpose of the change, and/or link to the JIRA ticket for context

Fixes UML-3808

Approach

Explain how your code addresses the purpose of the change

Learning

Any tips and tricks, blog posts or tools which helped you. Plus anything notable you've discovered about the Use a Lasting Power of Attorney service

Checklist (tick/delete or strikethrough as appropriate)

  • I have performed a self-review of my own code
  • I have added tests to prove my work
  • I have added relevant and appropriately leveled logging, without PII, to my code
  • New event_codes have been documented on the wiki page
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc)
  • I have added welsh translation tags and updated translation files
  • I have run an accessibility tool on any pages I have made changes to and fixed any issues found
  • I have notified the Interaction Designer of any content changes so that appropriate screenshots/flow diagram changes can be made
  • The product team have tested these changes

@jay-whitwell jay-whitwell requested a review from a team as a code owner January 28, 2025 12:09
@github-actions github-actions bot added the terraform Pull requests that update Terraform code label Jan 28, 2025
@jay-whitwell jay-whitwell merged commit 5b335fe into main Jan 29, 2025
26 checks passed
@jay-whitwell jay-whitwell deleted the UML-3808 branch January 29, 2025 16:58
jay-whitwell added a commit that referenced this pull request Jan 29, 2025
@jay-whitwell
Revert "UML-3808: allow api ecs access to secretsmanager (#3101)"
efa0fcf 
This reverts commit 5b335fe.
@jay-whitwell jay-whitwell mentioned this pull request Jan 29, 2025
Merged
jay-whitwell added a commit that referenced this pull request Jan 30, 2025
@jay-whitwell
Revert "UML-3808: allow api ecs access to secretsmanager (#3101)" (#3102
f8c6b80 
)

This reverts commit 5b335fe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cooperaj cooperaj cooperaj approved these changes

Assignees
No one assigned
Labels
terraform Pull requests that update Terraform code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jay-whitwell @cooperaj