Fix obsolete event.which for key testing #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
event.whichis obsolete and not even set in some browsers nor set by the latest syn.jsneeded for minkphp/MinkSelenium2Driver#358 PR otherwise workaround minkphp/MinkSelenium2Driver@cfb81e9 is needed and the native syn.js/better mapping cannot be used
here is an example from Firefox console on real keyboard presses:
notice the keyCode and charCode is set depending on the keyPress vs keyUp/keyDown event types
same test update is proposed also in #42, but this PR does not propose other test changes for easier review