Add rotation support for custom plane #367
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the GUI controls for plane manipulation. Specifically, it adds support for dynamic rotations around the local axes of the plane. The following changes were made:
Summary of Changes:
New Parameters:
Added tx, ty, and tz to the parameters.cp object to control rotations around the plane's local axes (x, y, and z).
New Rotation Functionality:
Implemented a new updatePlaneRotation function using quaternions to ensure the rotations are applied relative to the plane's current orientation. This ensures the following behaviors:
tx (Pitch): Rotates the plane around its local x-axis.
ty (Roll): Rotates the plane around its local y-axis.
tz (Yaw): Rotates the plane around its local z-axis.
Updated Controls:
Added GUI controls for:
tx: Pitch (rotation around local x-axis).
ty: Roll (rotation around local y-axis).
tz: Yaw (rotation around local z-axis).
Motivation:
This feature enhances the user experience, which is especially useful for applications involving 3D data visualization or modeling.
Any comment/ideas welcom