Web server orders routes #1841
Open
Web server orders routes #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azarovh
requested review from
erubboli,
ImplOfAnImpl and
OBorce
as code owners
OBorce
approved these changes
Nov 22, 2024
api-server/api-server-common/src/storage/impls/postgres/queries.rs
Outdated
Show resolved
Hide resolved
| SELECT order_id, initially_asked, ask_balance, ask_currency, initially_given, give_balance, give_currency, conclude_destination, next_nonce, creation_block_height, block_height, ROW_NUMBER() OVER(PARTITION BY order_id ORDER BY block_height DESC) as newest | ||
| FROM ml.orders | ||
| ) AS sub | ||
| WHERE newest = 1 AND ((ask_currency = $1 AND give_currency = $2) OR (ask_currency = $2 AND give_currency = $1)) |
There was a problem hiding this comment.
I am not sure on the OR if it is useful or not, if someone is searching to buy currency X it might not be very useful to give return results that both buy or sell X. Probably a question for the UI guys what they need.
There was a problem hiding this comment.
The idea was to provide a function to build order book as it displays both sell and buy prices. I think thats more common use case similar to exchanges.
Will ask Sergey for an opinion anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 routes were added: