Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table width at plugin detail page #2003

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

Rieven
Copy link
Contributor

@Rieven Rieven commented Nov 6, 2023

Changes

  • Make table width 100% by adding Manon class layout-wide

Issue link

#2002

Closes #2002

Proof

image


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified;
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Rieven Rieven requested a review from a team as a code owner November 6, 2023 13:14
@underdarknl
Copy link
Contributor

Does it need a class at all? Or would it just be 100% width without the column class?

@Rieven
Copy link
Contributor Author

Rieven commented Nov 7, 2023

Does it need a class at all? Or would it just be 100% width without the column class?

Yes, it needs a class, because the table is wrapped around a form, having the forn class inline will remove the grey area. Setting the layout-wide will make it max width. For tables without a form, a class is not needed.

@TwistMeister
Copy link
Contributor

Checklist for QA:

  • I have checked out this branch, and successfully ran a fresh make reset.
  • I confirmed that there are no unintended functional regressions in this branch:
    • I have managed to pass the onboarding flow
    • Objects and Findings are created properly
    • Tasks are created and completed properly
  • I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

Table seems as intended, again.
image

@underdarknl underdarknl merged commit b10eaf5 into main Nov 7, 2023
41 checks passed
@underdarknl underdarknl deleted the fix-table-width-plugin-detail branch November 7, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin detail object list table shows 50% table (does not span to full width)
3 participants