-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorting OOI List table by object type or clearance level #3320
Sorting OOI List table by object type or clearance level #3320
Conversation
…nvws/nl-kat-coordination into feature/sort-ooi-type-clearance-level
…nvws/nl-kat-coordination into feature/sort-ooi-type-clearance-level
…tyling, fixes text color
…ture/sort-ooi-type-clearance-level
…nvws/nl-kat-coordination into feature/sort-ooi-type-clearance-level
…n into feature/sort-ooi-type-clearance-level
…n into feature/sort-ooi-type-clearance-level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general; I have left one suggestion for the sorting properties
Co-authored-by: Jan Klopper <[email protected]> Co-authored-by: Rieven <[email protected]> Co-authored-by: Jeroen Dekkers <[email protected]>
Checklist for QA:
What works:Seems to work as expected. You can click on the Type and Clearance level on the Objects page and it will switch between ASC and DESC sorting. This also works when you have a search entry e.g. 'mispo.es'. What doesn't work:n/a Bug or feature?:n/a |
…ture/sort-ooi-type-clearance-level
…n into feature/sort-ooi-type-clearance-level
Co-authored-by: Peter-Paul van Gemerden <[email protected]>
Changes
Will add 2 sorting buttons in table header:
order_by
andasc_desc
Issue link
Closes #2735
Closes #3253
Demo
Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.
QA notes
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.