-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/dns loc records #3349
base: main
Are you sure you want to change the base?
Feat/dns loc records #3349
Conversation
Co-authored-by: ammar92 <[email protected]>
Co-authored-by: Jan Klopper <[email protected]>
Co-authored-by: Jan Klopper <[email protected]>
Co-authored-by: Jan Klopper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I just have a few remarks that could improve this even more. Let me know what you think
Normalizer fails on the following error:
|
Could you perhaps share the input you're targetting (or raw file)? This would help with debugging |
I think we need to update dnspython, will check today. |
This seems to be #2805 |
Changes
Adds LOC and GPOS records to octopoes and dns boefje.
Demo
Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.
QA notes
Please add some information for QA on how to test the newly created code.
Code Checklist
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.