Add sterr to output list #3649
Add sterr to output list #3649
Conversation
|
Important to think about. |
| results = [({"openkat/nmap-output"}, output.stdout.decode())] | ||
|
|
||
| if output.stderr: | ||
| return results.append(({"error/boefje"}, output.stderr.decode())) |
There was a problem hiding this comment.
| return results.append(({"error/boefje"}, output.stderr.decode())) | |
| if not output.stdout: | |
| results = [] | |
| return results.append(({"error/boefje"}, output.stderr.decode())) |
There was a problem hiding this comment.
I also made a push. That should also cover this, right?
There was a problem hiding this comment.
Your solution makes sure we don't Delete any previous proofs.
My suggestions allows for a situation where we still have some logical output that we'd want to ingest into the graph, but also some errors (which did not stop us from creating data). The million dollar question is: 'is there a situation where nmap throws errors, but still manages to produce valid output?'
There was a problem hiding this comment.
Haha yeah good question. To be honest I don't think so. Im more inclined to be on the safe side and never delete old observations. If you feel like there are situations when nmap throws errors & good output, then I'm happy to rewrite it to your solution.
|
|
I tested it and verified that the boefje still works. If I introduce an error the boefje will get failed status. The stderr of the command is not saved as is mentioned in the description because the exception is not catched. But this part is already useful, so I am merging the PR and creating a new issue. |
* main: (25 commits) Add sterr to output list (#3649) feat: ✨ add Shodan InternetDB boefje (#2615) Add search endpoint for schedules for scheduler (#3695) Fix/report naming (#3666) Add delete schedule functionality for schedules in the scheduler (#3678) Fix javascript and component template in prod environments (#3672) Fix first order dangling affirmation delete (#3682) Do not run dh_strip_nondeterminism in Debian packaging (#3674) Github action should trigger if workflow definition changes (#3680) Updated packages (#3694) Silence KATFindingType not found error in JobHandler (#3686) Add docs for xtdb analyze bits. (#3688) Fix empty vulnerability reports (#3662) Fix jsonb 'contained by' query (#3643) Add plugins to findings report (#3657) Translations update from Hosted Weblate (#3673) Update upload_raw.py (#3645) Add rocky worker service to debian packages (#3619) Fix/yielded objects (#3669) make some things look better (#3661) ...
Changes
Also save sterr to bytes for docker boefjes
Issue link
Closes #3559
Demo
Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.
QA notes
Please add some information for QA on how to test the newly created code.
Code Checklist
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.