Update disallowed_csp_hostnames.py, also trigger on higher level denied domains #3980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed domains If a subdomain of a denied domain is listed, we should warn. Eg, if www.badexample.com is used in the CSP, but badexample.com is listed we should trigger.
|
|
This PR has been ported to feature/nibbles see 15304bc. |
Donnype
approved these changes
Dec 19, 2024
Comment on lines
+34
to
+41
| hostnameparts = hostname.lower().split(".") | ||
| for i in range(len(hostnameparts)): | ||
| if ".".join(hostnameparts[i:]) in disallowed_domains: | ||
| ft = KATFindingType(id="KAT-DISALLOWED-DOMAIN-IN-CSP") | ||
| f = Finding(ooi=input_ooi.reference, finding_type=ft.reference) | ||
| yield ft | ||
| yield f | ||
| break |
There was a problem hiding this comment.
Suggested change
| hostnameparts = hostname.lower().split(".") | |
| for i in range(len(hostnameparts)): | |
| if ".".join(hostnameparts[i:]) in disallowed_domains: | |
| ft = KATFindingType(id="KAT-DISALLOWED-DOMAIN-IN-CSP") | |
| f = Finding(ooi=input_ooi.reference, finding_type=ft.reference) | |
| yield ft | |
| yield f | |
| break | |
| hostnameparts = hostname.lower().split(".") | |
| # For e.g. ["www", "example", "com"], check "www.example.com", "example.com" and "com" | |
| for i in range(len(hostnameparts)): | |
| if ".".join(hostnameparts[i:]) in disallowed_domains: | |
| ft = KATFindingType(id="KAT-DISALLOWED-DOMAIN-IN-CSP") | |
| f = Finding(ooi=input_ooi.reference, finding_type=ft.reference) | |
| yield ft | |
| yield f | |
| break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a subdomain of a denied domain is listed, we should warn. Eg, if www.badexample.com is used in the CSP, but badexample.com is listed we should trigger.
Changes
Loops over the parts of the listed hostname, and looks for the parent domains to check if they are listed.
Issue link
You have to create an issue to link to this PR. If this really is not possible, write a very detailed description here and add this PR to the project board directly.
Please add the link to the issue after "Closes".
Closes #3979
Demo
Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.
QA notes
Please add some information for QA on how to test the newly created code.
Code Checklist
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.