Rewrite the dns_alias_resolving bit to a nibble #4022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ery logic (ai generated woo)
…on into feature/nibbles
|
Thank you so much this nibbly contribution! It is much appreciated. Could you please consider also adding an integration test to ensure that the new implementation is functioning as we expect? It would really help us confirm that everything is working as intended. Thanks! |
|
@originalsouth are these tests to your liking? If not, I would love to hear what parts you want to be tested. |
|
Excellent work @Souf149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you feline good today, or are you just paws-ing through the motions?