Skip to content

Commit

Permalink
Merge pull request #814 from ElderOrb/#812
Browse files Browse the repository at this point in the history
use ignore and merge options for frame filtering #812
  • Loading branch information
dericed authored Jan 31, 2024
2 parents ae0afe0 + 067945f commit c0bba3c
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 2 deletions.
14 changes: 14 additions & 0 deletions Source/GUI/dvrescue/dvrescue/CapturePage.qml
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,7 @@ Rectangle {
['--decklink-audio-source', decklinkConfigPopup.audioSourcesModel[currentAudioSourceIndex]],
['--decklink-timecode-format', decklinkConfigPopup.timecodesModel[currentTimecodesIndex]],
)

return opts;
}

Expand Down Expand Up @@ -294,6 +295,19 @@ Rectangle {
}

statusText = "sending record";

if(settings.keepFramesAtNonStandardPlaybackSpeed) {
opts.push('--merge-output-speed');
} else {
opts.push('--merge-ignore-speed');
}

if(settings.keepFramesThatAllFullyConcealed) {
opts.push('--merge-output-concealed');
} else {
opts.push('--merge-ignore-concealed');
}

dvrescue.grab(id, filePath, playbackBuffer, csvParser, opts, (launcher) => {
outputFilePath = filePath
csvParser.columnsChanged.connect(onColumnsChanged);
Expand Down
4 changes: 2 additions & 2 deletions Source/GUI/dvrescue/dvrescue/DvRescueCLI.qml
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ Item {
callback(launcher)
});

var arguments = ['-y', 'device://' + id].concat(opts).concat(['-capture', '-cmd', captureCmd, '-m', '-', '--verbosity', '9', '--csv'])
var arguments = ['-y', 'device://' + id].concat(opts).concat(['-capture', '-cmd', captureCmd, '--merge-output-speed', '--merge-output-concealed', '-m', '-', '--verbosity', '9', '--csv'])

if(settings.endTheCaptureIftheTapeContainsNoDataFor && settings.endTheCaptureIftheTapeContainsNoDataFor !== '') {
arguments.push('--timeout')
Expand Down Expand Up @@ -285,7 +285,7 @@ Item {
var xml = file + ".dvrescue.xml"
var scc = file + ".scc"

var arguments = ['-y', 'device://' + id].concat(opts).concat(['-x', xml, '-c', scc, '--cc-format', 'scc', '-m', file, '-m', '-', '--verbosity', '9', '--csv'])
var arguments = ['-y', 'device://' + id].concat(opts).concat(['-x', xml, '-c', scc, '--cc-format', 'scc', '-m', file, '--merge-output-speed', '--merge-output-concealed', '-m', '-', '--verbosity', '9', '--csv'])

if(settings.endTheCaptureIftheTapeContainsNoDataFor && settings.endTheCaptureIftheTapeContainsNoDataFor !== '') {
arguments.push('--timeout')
Expand Down

0 comments on commit c0bba3c

Please sign in to comment.