Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --merge-*-speed and --merge-*-concealed output specific #810

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

g-maxime
Copy link
Collaborator

@g-maxime g-maxime commented Jan 8, 2024

No description provided.

@dericed
Copy link
Contributor

dericed commented Jan 12, 2024

is this feature in the latest daily builds? @g-maxime @JeromeMartinez

@dericed
Copy link
Contributor

dericed commented Jan 16, 2024

Thx, this worked well with dvrescue device://0 --merge-output-speed --merge-output-concealed -m speed_concealed.dv --merge-ignore-speed --merge-ignore-concealed -m nospeed_noconcealed.dv --merge-output-speed --merge-ignore-concealed -m speed_noconcealed.dv --merge-ignore-speed --merge-output-concealed -m nospeed_concealed.dv

Though I noticed without the input reference, such as dvrescue --merge-output-speed --merge-output-concealed -m speed_concealed.dv --merge-ignore-speed --merge-ignore-concealed -m nospeed_noconcealed.dv --merge-output-speed --merge-ignore-concealed -m speed_noconcealed.dv --merge-ignore-speed --merge-output-concealed -m nospeed_concealed.dv then the command seems invalid (though I thought with no input then device://0 would be default).

I also realize that perhaps the xml and scc outputs also need to be output specific. In the example above the 4 outputs should have different xmls.

@dericed dericed marked this pull request as ready for review January 16, 2024 16:45
@dericed dericed merged commit 41c3200 into mipops:main Jan 16, 2024
12 checks passed
@JeromeMartinez JeromeMartinez deleted the merge-options branch June 19, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants