-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CR] matplotlib modernization #380
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
b8a9396
hacking toward display revisions, not yet finished but want to test o…
bmcfee afc9c68
fixed #332, pitch contour sonification supports nans (#379)
bmcfee 76a121e
fixing up test fixtures
bmcfee 5e52bf5
correcting fixture names and paths for display
bmcfee 81980ce
fixing separation
bmcfee ac9c9d4
toward a working implementation of axes weakkeydict storage
bmcfee 7390d25
updated mpl regression tests for labeled intervals
bmcfee 712d84d
fixing up ticks and margins
bmcfee 3726875
updated hierarchy fixtures
bmcfee d5b6836
revised separation display to use property cyclers
bmcfee bb505f3
working through some matplotlib hackery
bmcfee a4ae35c
almost done modernizing mpl code...
bmcfee 771bf91
very nearly done modernizing
bmcfee e78d994
docs and styling
bmcfee 935db0d
rewrote segments to use axvspans
bmcfee a86f96d
blacked tests
bmcfee f442431
skip segment with text plot tests on old matplotlib
bmcfee 89aae62
blacked tests
bmcfee 414bddf
skip certain tests when using old versions of freetype
bmcfee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed
BIN
-18 KB
tests/baseline_images/test_display/labeled_intervals_compare_common.png
Binary file not shown.
Binary file removed
BIN
-11.5 KB
tests/baseline_images/test_display/labeled_intervals_compare_noextend.png
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+11.3 KB
tests/baseline_images/test_display/test_display_hierarchy_nolabel.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+7.81 KB
tests/baseline_images/test_display/test_display_labeled_intervals.png
Oops, something went wrong.
Binary file added
BIN
+17.3 KB
tests/baseline_images/test_display/test_display_labeled_intervals_compare.png
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment on the whitespace on the top here, so is a common feature |
Oops, something went wrong.
Binary file added
BIN
+17.4 KB
.../baseline_images/test_display/test_display_labeled_intervals_compare_common.png
Oops, something went wrong.
Binary file added
BIN
+10.8 KB
...aseline_images/test_display/test_display_labeled_intervals_compare_noextend.png
Oops, something went wrong.
Binary file added
BIN
+7.81 KB
tests/baseline_images/test_display/test_display_labeled_intervals_noextend.png
Oops, something went wrong.
Binary file added
BIN
+21.8 KB
tests/baseline_images/test_display/test_display_multipitch_hz_unvoiced.png
Oops, something went wrong.
Binary file added
BIN
+21.8 KB
tests/baseline_images/test_display/test_display_multipitch_hz_voiced.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Diff not rendered.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is just due to plot ranges, but there's now a little blip on "z" at time zero. Also a nit but it's a bit odd that the upper plot has some whitespace at the top.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the whitespace is due to matplotlib margin handling, and it's on all edges. This is configurable at the rcParams level or by calling
ax.margins()
, but it's not something that artist constructors should be styling directly.The blip on "z" is correct if you look at the source annotations: https://github.com/craffel/mir_eval/blob/main/tests/data/hierarchy/ref00.lab and https://github.com/craffel/mir_eval/blob/main/tests/data/hierarchy/ref01.lab - they were always in the plots, but the old styling made them difficult to see due to axis spines.