Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial first draft version #1

Merged
merged 1 commit into from
Feb 23, 2024
Merged

feat: initial first draft version #1

merged 1 commit into from
Feb 23, 2024

Conversation

chgl
Copy link
Contributor

@chgl chgl commented Feb 23, 2024

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

src/PathlingS3Import/Program.cs Fixed Show fixed Hide fixed
src/PathlingS3Import/Program.cs Fixed Show fixed Hide fixed
src/PathlingS3Import/Program.cs Fixed Show fixed Hide fixed
Copy link

github-actions bot commented Feb 23, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 3 0 0.6s
✅ CSHARP csharpier 2 0 1.52s
⚠️ CSHARP roslynator 1 1 9.52s
✅ DOCKERFILE hadolint 1 0 0.07s
✅ EDITORCONFIG editorconfig-checker 20 0 0.03s
✅ JSON eslint-plugin-jsonc 3 0 1.37s
✅ JSON jsonlint 3 0 0.25s
✅ JSON prettier 3 0 0.83s
✅ JSON v8r 3 0 2.57s
⚠️ MARKDOWN markdownlint 1 1 0.53s
✅ REPOSITORY checkov yes no 11.83s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 0.15s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 12.31s
✅ REPOSITORY kics yes no 6.04s
✅ REPOSITORY secretlint yes no 1.04s
✅ REPOSITORY syft yes no 0.42s
✅ REPOSITORY trivy yes no 5.27s
✅ REPOSITORY trivy-sbom yes no 4.97s
✅ REPOSITORY trufflehog yes no 9.51s
✅ YAML prettier 5 0 0.7s
✅ YAML v8r 5 0 7.98s
✅ YAML yamllint 5 0 0.42s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

}
);

using var minio = new MinioClient()

Check warning

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning

Disposable 'MinioClient' is created but not disposed.
Comment on lines +97 to +135
foreach (var item in allObjects)
{
var objectUrl = $"s3://{S3BucketName}/{item.Key}";

var parameter = new Parameters.ParameterComponent()
{
Name = "source",
Part =
[
new Parameters.ParameterComponent()
{
Name = "resourceType",
Value = new Code(ImportResourceType.ToString())
},
new Parameters.ParameterComponent()
{
Name = "mode",
Value = new Code("merge")
},
new Parameters.ParameterComponent()
{
Name = "url",
Value = new FhirUrl(objectUrl)
}
]
};

var importParameters = new Parameters();
// for now, create one Import request per file. In the future,
// we might want to add multiple ndjson files at once in batches.
importParameters.Parameter.Add(parameter);

Console.WriteLine(importParameters.ToJson());

Console.WriteLine($"Running {PathlingServerBaseUrl}/$import for {objectUrl}");

var response = await fhirClient.WholeSystemOperationAsync("import", importParameters);
Console.WriteLine(response.ToJson());
}

Check notice

Code scanning / CodeQL

Missed opportunity to use Select Note

This foreach loop immediately
maps its iteration variable to another variable
- consider mapping the sequence explicitly using '.Select(...)'.
@chgl chgl merged commit ee40a70 into master Feb 23, 2024
10 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 23, 2024
## 1.0.0 (2024-02-23)

### Features

* initial first draft version ([#1](#1)) ([ee40a70](ee40a70))

### Miscellaneous Chores

* fix for first release ([af2bed8](af2bed8))
* fix release config ([6c9f831](6c9f831))
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@chgl chgl deleted the first-version branch February 24, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant