Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved tab and directional navigation #200

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miroiu
Copy link
Owner

@miroiu miroiu commented Jan 10, 2025

📝 Description of the Change

  • Automatically bring item containers into view when navigating to them via keyboard if they are not already in view
  • Enable directional navigation for item containers within the editor

Closes #194

🐛 Possible Drawbacks

None.

@Nintynuts
Copy link

Nintynuts commented Feb 13, 2025

It's great you're improving this, so thanks.

For me in the current version, with the focus rect style overridden (as you have in this review) it results in a connection-shaped rectange appearing when trying to tab navigate (it tabs through all the connections before the nodes), but all the rects are anchored to 0,0 on the canvas rather than around the connection. This seems to be because they're added to a canvas, but their left and top properties are not set. I'm guessing that ConnectionContainer overrides Focusable to true because the connections are shapes and aren't focusable themselves? Maybe if the container could know the top left position of the shape and the shape was anchored so its bounds line up with 0,0 in its local coordinate space it would work? If not maybe the focus rect should just be disabled for them and change the connection drawing to indicate focus instead.

Do you still see those issues with these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Improve keyboard navigation
2 participants