Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add #16

Merged
merged 4 commits into from
Feb 19, 2025
Merged

add #16

merged 4 commits into from
Feb 19, 2025

Conversation

mirooon
Copy link
Owner

@mirooon mirooon commented Feb 19, 2025

Which Jira task belongs to this PR?

Why did I implement it this way?

Checklist before requesting a review

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

  • I have checked that any arbitrary calls to external contracts are validated and or restricted
  • I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
  • I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

@mirooon mirooon marked this pull request as ready for review February 19, 2025 10:40
@mirooon mirooon marked this pull request as draft February 19, 2025 10:44
@mirooon mirooon marked this pull request as ready for review February 19, 2025 10:44
@mirooon mirooon marked this pull request as draft February 19, 2025 11:09
@mirooon mirooon marked this pull request as ready for review February 19, 2025 11:09
Copy link

github-actions bot commented Feb 19, 2025

🤖 GitHub Action: Security Alerts Review 🔍

🟢 Dismissed Security Alerts with Comments
The following alerts were dismissed with proper comments:

🟢 View Alert - File: src/Facets/OmniBridgeFacet8.sol
🔹 Test functions fail to thoroughly test all aspects of contract constructors, potentially missing critical initialization issues. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/incomplete-constructor-tests
🔹 Dismiss Reason: False positive
🔹 Dismiss Comment: d

🟢 View Alert - File: src/Facets/OmniBridgeFacet8.sol
🔹 The contract contains functions with inadequate validation of input parameters, potentially leading to unexpected behavior or vulnerabilities. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/insufficient-parameter-assertion
🔹 Dismiss Reason: False positive
🔹 Dismiss Comment: d

🟢 View Alert - File: src/Facets/OmniBridgeFacet8.sol
🔹 Parameters passed to a constructor that are not validated for correct values may lead to contract creation in an undesired state. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/no-parameter-validation-in-constructor
🔹 Dismiss Reason: False positive
🔹 Dismiss Comment: d

🟢 View Alert - File: src/Facets/OmniBridgeFacet8.sol
🔹 Parameters passed to a constructor that are not validated for correct values may lead to contract creation in an undesired state. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/no-parameter-validation-in-constructor
🔹 Dismiss Reason: False positive
🔹 Dismiss Comment: d

No unresolved security alerts! 🎉

@github-actions github-actions bot marked this pull request as draft February 19, 2025 11:09
@mirooon mirooon marked this pull request as ready for review February 19, 2025 11:15
@github-actions github-actions bot marked this pull request as draft February 19, 2025 11:15
@mirooon mirooon marked this pull request as ready for review February 19, 2025 11:15
@mirooon mirooon merged commit f2f122c into main Feb 19, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant