-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redo GraphQL enum fixing logic #1138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1138 +/- ##
========================================
Coverage 97.85% 97.85%
========================================
Files 106 109 +3
Lines 7677 7865 +188
========================================
+ Hits 7512 7696 +184
- Misses 165 169 +4 ☔ View full report in Codecov by Sentry. |
rafalp
changed the title
Fix 1136 update graphql enum fixing logic
Redo GraphQL enum fixing logic
Dec 13, 2023
rafalp
added
enhancement
New feature or request
critical
Should be prioritized before other work
labels
Dec 14, 2023
mat-sop
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes existing utilities for fixing GraphQL enum handling and introduces two new ones:
repair_schema_default_enum_values
: repairs Python representation of default GraphQL enum values in schema.validate_schema_default_enum_values
: validiates that GraphQL enum values in schema are valid.Fixes #1136