Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo GraphQL enum fixing logic #1138

Merged
merged 12 commits into from
Dec 15, 2023
Merged

Conversation

rafalp
Copy link
Collaborator

@rafalp rafalp commented Dec 13, 2023

This PR removes existing utilities for fixing GraphQL enum handling and introduces two new ones:

  • repair_schema_default_enum_values: repairs Python representation of default GraphQL enum values in schema.
  • validate_schema_default_enum_values: validiates that GraphQL enum values in schema are valid.

Fixes #1136

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (010f551) 97.85% compared to head (6f1f4da) 97.85%.
Report is 11 commits behind head on master.

Files Patch % Lines
ariadne/enums_values_visitor.py 97.19% 5 Missing ⚠️
ariadne/enums.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1138    +/-   ##
========================================
  Coverage   97.85%   97.85%            
========================================
  Files         106      109     +3     
  Lines        7677     7865   +188     
========================================
+ Hits         7512     7696   +184     
- Misses        165      169     +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafalp rafalp changed the title Fix 1136 update graphql enum fixing logic Redo GraphQL enum fixing logic Dec 13, 2023
@rafalp rafalp self-assigned this Dec 14, 2023
@rafalp rafalp added enhancement New feature or request critical Should be prioritized before other work labels Dec 14, 2023
@rafalp rafalp added this to the Next release milestone Dec 14, 2023
@rafalp rafalp marked this pull request as ready for review December 14, 2023 17:44
@rafalp rafalp requested a review from mat-sop December 14, 2023 18:05
@rafalp rafalp merged commit c4cdefb into master Dec 15, 2023
22 checks passed
@rafalp rafalp deleted the fix-1136-update-graphql-enum-fixing-logic branch December 15, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical Should be prioritized before other work enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update GraphQL fixing logic
2 participants