Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GraphQLTransportWSHandler returning invalid error message for query and mutation errors. #1139

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

rafalp
Copy link
Collaborator

@rafalp rafalp commented Dec 15, 2023

Fixes #1053

@rafalp rafalp added this to the Next release milestone Dec 15, 2023
@rafalp rafalp self-assigned this Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c4cdefb) 97.85% compared to head (7a55fe9) 97.84%.
Report is 5 commits behind head on master.

Files Patch % Lines
ariadne/asgi/handlers/graphql_transport_ws.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1139      +/-   ##
==========================================
- Coverage   97.85%   97.84%   -0.01%     
==========================================
  Files         109      109              
  Lines        7865     7878      +13     
==========================================
+ Hits         7696     7708      +12     
- Misses        169      170       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafalp rafalp marked this pull request as ready for review December 15, 2023 18:15
@rafalp rafalp requested a review from mat-sop December 15, 2023 18:15
@rafalp rafalp merged commit 94b8729 into master Jan 8, 2024
21 of 22 checks passed
@rafalp rafalp deleted the fix-1053-ws-error-format branch January 8, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants