Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

24w10a #52

Merged
merged 10 commits into from
Mar 6, 2024
Merged

24w10a #52

merged 10 commits into from
Mar 6, 2024

Conversation

Apollounknowndev
Copy link
Contributor

@Apollounknowndev Apollounknowndev commented Mar 6, 2024 •
edited
Loading

Todo:

  • Banner patterns
  • Wolf variants
  • Components in recipes
  • Misc. item component changes
  • Slot predicate

@Apollounknowndev
Banner pattern schema
8c985a8
@Apollounknowndev
Wolf variants
8bb39fd
@Apollounknowndev
Components in recipes
225095b
@Apollounknowndev
Component changes I
5ef7e2f 
Optional profile name, firework/lore max increase, lodestone tracker
misode
misode reviewed Mar 6, 2024
View reviewed changes
Copy link
Owner

@misode misode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't comment on Components yet

java/1.20.5/src/schemas/Recipe.ts Outdated Show resolved Hide resolved
java/1.20.5/package.json Outdated Show resolved Hide resolved
java/1.20.5/src/schemas/index.ts Outdated Show resolved Hide resolved
java/1.20.5/src/schemas/WolfVariant.ts Outdated Show resolved Hide resolved
@Apollounknowndev
Copy link
Contributor Author

That should be all of the component changes, just remembered the slot field was added so I'll work on that next and that should be everything

@Apollounknowndev
Copy link
Contributor Author

Since there are so many possible slot values (161 total I think?), I currently have the keys for the slot field accept any string but have the collection slots (container.*, enderchest.*, etc.) suggested by default. Might not be the best solution, I can change it if needed.

@Apollounknowndev Apollounknowndev marked this pull request as ready for review March 6, 2024 18:53
@Apollounknowndev Apollounknowndev requested a review from misode March 6, 2024 19:09
misode
misode approved these changes Mar 6, 2024
View reviewed changes
Copy link
Owner

@misode misode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this!

@misode misode merged commit 9720e86 into misode:master Mar 6, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misode misode misode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Apollounknowndev @misode