Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Misskey Gamesのプレイ可否をロールで制限できるように #14955

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Nov 14, 2024

What

かいてあるとおり

Why

Fix #13111

Additional info (optional)

APIをガチガチにしてあるけどここまでやる必要があるかは謎

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Nov 14, 2024
@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft November 14, 2024 07:27
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 22.01258% with 124 lines in your changes missing coverage. Please review.

Project coverage is 41.56%. Comparing base (4d54101) to head (1d31ce3).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/reversi/index.vue 0.00% 42 Missing ⚠️
.../backend/src/server/api/endpoints/reversi/match.ts 31.03% 20 Missing ⚠️
packages/frontend/src/pages/admin/roles.editor.vue 0.00% 20 Missing ⚠️
packages/backend/src/core/ReversiService.ts 18.75% 13 Missing ⚠️
packages/frontend/src/pages/admin/roles.vue 0.00% 8 Missing ⚠️
.../backend/src/server/api/endpoints/reversi/games.ts 25.00% 6 Missing ⚠️
packages/frontend/src/pages/drop-and-fusion.vue 0.00% 6 Missing ⚠️
...nd/src/server/api/endpoints/reversi/invitations.ts 37.50% 5 Missing ⚠️
packages/backend/src/misc/prelude/array.ts 40.00% 3 Missing ⚠️
packages/frontend/src/pages/reversi/game.board.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14955      +/-   ##
===========================================
- Coverage    41.73%   41.56%   -0.17%     
===========================================
  Files         1564     1564              
  Lines       202871   203012     +141     
  Branches      3670     3690      +20     
===========================================
- Hits         84660    84381     -279     
- Misses      117605   118023     +418     
- Partials       606      608       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 14, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -76541,6 +76541,15 @@
                       }
                     }
                   },
+                  "TARGET_IS_NOT_AVAILABLE": {
+                    "value": {
+                      "error": {
+                        "message": "You or target user is not available due to server policy.",
+                        "code": "TARGET_IS_NOT_AVAILABLE",
+                        "id": "3a8a677f-98e5-4c4d-b059-e5874b44bd4f"
+                      }
+                    }
+                  },
                   "INVALID_PARAM": {
                     "value": {
                       "error": {
@@ -81820,6 +81829,9 @@
           },
           "canImportUserLists": {
             "type": "boolean"
+          },
+          "canPlayGames": {
+            "type": "boolean"
           }
         },
         "required": [
@@ -81853,7 +81865,8 @@
           "canImportBlocking",
           "canImportFollowing",
           "canImportMuting",
-          "canImportUserLists"
+          "canImportUserLists",
+          "canPlayGames"
         ]
       },
       "ReversiGameLite": {

Get diff files from Workflow Page

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review November 14, 2024 07:39
locales/ja-JP.yml Outdated Show resolved Hide resolved
locales/ja-JP.yml Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

プレイできないというより「ランキングに記録を残せない」方が良さそう(クライアントで完結してサーバーや他のユーザーに影響を一切与えないものを制限する必要はないと思われるため)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(games) プレイ可否のロール制御ができるように
2 participants