Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(backend): アクセストークンでアカウントを作成できるように #14989

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

eternal-flame-AD
Copy link
Contributor

What

Fixes #14959

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 41.66%. Comparing base (eed45c7) to head (f767c22).

Files with missing lines Patch % Lines
.../src/server/api/endpoints/admin/accounts/create.ts 33.33% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14989      +/-   ##
===========================================
+ Coverage    39.97%   41.66%   +1.69%     
===========================================
  Files         1561     1565       +4     
  Lines       197256   203042    +5786     
  Branches      3607     3640      +33     
===========================================
+ Hits         78849    84597    +5748     
- Misses      117835   117839       +4     
- Partials       572      606      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -2050,6 +2050,7 @@
                   "ACCESS_DENIED": {
                     "value": {
                       "error": {
+                        "httpStatusCode": 403,
                         "message": "Access denied.",
                         "code": "ACCESS_DENIED",
                         "id": "1fb7cb09-d46a-4fff-b8df-057708cce513"
@@ -2059,6 +2060,7 @@
                   "INCORRECT_INITIAL_PASSWORD": {
                     "value": {
                       "error": {
+                        "httpStatusCode": 401,
                         "message": "Initial password is incorrect.",
                         "code": "INCORRECT_INITIAL_PASSWORD",
                         "id": "97147c55-1ae1-4f6f-91d6-e1c3e0e76d62"

Get diff files from Workflow Page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endpoint /admin/accounts/create をアクセストークンから使用出来るように欲しい
1 participant