-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backend): URLをデコードしてからリクエストを送信するように #15015
base: develop
Are you sure you want to change the base?
Conversation
このPRによるapi.jsonの差分 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #15015 +/- ##
===========================================
- Coverage 39.98% 39.86% -0.12%
===========================================
Files 1563 1563
Lines 197737 197739 +2
Branches 3644 3629 -15
===========================================
- Hits 79056 78829 -227
- Misses 118077 118303 +226
- Partials 604 607 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
APIの実装側はパラメータがエンコードされて送られてきているといった知識を持つべきではないから、HTTPについて関心を持つAPI実装を呼び出す側でハンドリングするのが良さそうです |
|
HttpRequestService側で処理するように変更しました。意図していたものとは異なる可能性もありますが...
#15015 (comment) |
What
Fix #15014
Why
現状はURLがデコードされていないのでリクエストに失敗してRSSが取得できないため
Additional info (optional)
Checklist